[SPARK-13055] SQLHistoryListener throws ClassCastException #10971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 28, 2016 13:24
This is currently not used, but will be populated by SQLMetrics in the ensuing commits.
SQLMetrics will override this in the next commit to set some custom metadata in the AccumulableInfo it returns.
This should fix the ClassCastException since all SQL metrics are (for now) Long.
andrewor14
force-pushed
the
fix-sql-history
branch
from
14d34fe to
c6f41d1
Compare
Contributor
Author
|
Test build #50314 has finished for PR 10971 at commit
|
Member
|
LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an existing issue uncovered recently by #10835. The reason for the exception was because the
SQLHistoryListenergets all sorts of accumulators, not just the ones that represent SQL metrics. For example, the listener gets theinternal.metrics.shuffleRead.remoteBlocksFetched, which is an Int, then it proceeds to cast the Int to a Long, which fails.The fix is to mark accumulators representing SQL metrics using some internal metadata. Then we can identify which ones are SQL metrics and only process those in the
SQLHistoryListener.