Skip to content

Conversation

@ajbozarth
Copy link
Member

A dependency on the spark test tags was left out of the sketch module pom file causing builds to fail when test tags were used. This dependency is found in the pom file for every other module in spark.

@SparkQA
Copy link

SparkQA commented Jan 27, 2016

Test build #50221 has finished for PR 10954 at commit 6ab0ec9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor

holdenk commented Jan 28, 2016

This looks reasonable to me, maybe @liancheng who added the sketch build file can take a look as well?

@ajbozarth
Copy link
Member Author

Also looping in @rxin and @JoshRosen since they were in on #10851 which caused this

@holdenk
Copy link
Contributor

holdenk commented Jan 28, 2016

Would it maybe be a good idea to add a test for this to the jenkins scripts?

@liancheng
Copy link
Contributor

One of the requirements of the spark-sketch module is to have zero external runtime dependencies. Is it possible to make it a test dependency? It seems quite reasonable since those tags are only used in test code.

@liancheng
Copy link
Contributor

Hm, but I do find that spark-test-tags is listed as default compile dependency in other modules. Is that necessary? @JoshRosen

@vanzin
Copy link
Contributor

vanzin commented Jan 29, 2016

spark-test-tags is declared with a test scope in the root pom, and the scope is inherited. You can check these things with mvn dependency:tree.

@liancheng
Copy link
Contributor

@vanzin I see, thanks for the explanation! Then this LGTM.

@liancheng
Copy link
Contributor

I'm merging this. Thanks for fixing and reviewing this!

@asfgit asfgit closed this in 8d3cc3d Jan 29, 2016
@ajbozarth ajbozarth deleted the spark13050 branch January 29, 2016 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants