Skip to content

[SPARK-12637] [CORE] Print stage info of finished stages properly #10922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-12637] [CORE] Print stage info of finished stages properly #10922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00ff9a1
Improve printing of StageInfo in onStageCompleted
srowen Jan 26, 2016
4e997a2
Fix compile error from escaped quote (?)
srowen Jan 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ class StatsReportListener extends SparkListener with Logging {

override def onStageCompleted(stageCompleted: SparkListenerStageCompleted) {
implicit val sc = stageCompleted
this.logInfo("Finished stage: " + stageCompleted.stageInfo)
this.logInfo(s"Finished stage: ${getStatusDetail(stageCompleted.stageInfo)}")
showMillisDistribution("task runtime:", (info, _) => Some(info.duration), taskInfoMetrics)

// Shuffle write
Expand All @@ -296,6 +296,17 @@ class StatsReportListener extends SparkListener with Logging {
taskInfoMetrics.clear()
}

private def getStatusDetail(info: StageInfo): String = {
val failureReason = info.failureReason.map("(" + _ + ")").getOrElse("")
Copy link
Contributor

@andrewor14 andrewor14 Feb 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just do ($failureReason) down there?

Copy link
Member Author

@srowen srowen Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would produce an empty () when it didn't exist or that was the intent I was just following.

Copy link
Contributor

@andrewor14 andrewor14 Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah you're right never mind

val timeTaken = info.submissionTime.map(
x => info.completionTime.getOrElse(System.currentTimeMillis()) - x
).getOrElse("-")

s"Stage(${info.stageId}, ${info.attemptId}); Name: '${info.name}'; " +
s"Status: ${info.getStatusString}$failureReason; numTasks: ${info.numTasks}; " +
s"Took: $timeTaken msec"
}

}

private[spark] object StatsReportListener extends Logging {
Expand Down