Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Jan 26, 2016

JIRA: https://issues.apache.org/jira/browse/SPARK-12968

Implement command to set current database.

@rxin
Copy link
Contributor

rxin commented Jan 26, 2016

cc @hvanhovell for review.

@SparkQA
Copy link

SparkQA commented Jan 26, 2016

Test build #50071 has finished for PR 10916 at commit 46737b5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class SetDatabaseCommand(databaseName: String) extends RunnableCommand

@viirya
Copy link
Member Author

viirya commented Jan 26, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented Jan 26, 2016

Test build #50079 has finished for PR 10916 at commit 43beb4b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 26, 2016

Test build #50088 has finished for PR 10916 at commit ee237e4.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 26, 2016

Test build #50090 has finished for PR 10916 at commit bffae43.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 26, 2016

Test build #50104 has finished for PR 10916 at commit 9df380f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a dumb idea: we could return Ok...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return OK will break hive compatibility test. I've tried in previous commits.

@rxin
Copy link
Contributor

rxin commented Jan 29, 2016

@viirya can you remove ur last commit? I can merge this. I'm redesigning catalog right now and we don't need to add that no-op commit here.

@viirya
Copy link
Member Author

viirya commented Jan 29, 2016

@rxin ok. I will update this later (about 30 mins) when I am back to desk.

@SparkQA
Copy link

SparkQA commented Jan 29, 2016

Test build #50337 has finished for PR 10916 at commit 87c27ef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jan 29, 2016

@rxin I've reverted last commit.

@rxin
Copy link
Contributor

rxin commented Jan 29, 2016

Thanks - I've merged this.

@asfgit asfgit closed this in 66449b8 Jan 29, 2016
@SparkQA
Copy link

SparkQA commented Jan 29, 2016

Test build #50350 has finished for PR 10916 at commit ff5508b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya viirya deleted the ddl-use-database branch December 27, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants