Skip to content

Conversation

@tedyu
Copy link
Contributor

@tedyu tedyu commented Jan 25, 2016

@liancheng please take a look

@SparkQA
Copy link

SparkQA commented Jan 26, 2016

Test build #50041 has finished for PR 10906 at commit e400a17.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Jan 26, 2016

I guess the caller should close the stream?

@tedyu
Copy link
Contributor Author

tedyu commented Jan 26, 2016

Looking at current code, that is not the case.

@zsxwing
Copy link
Member

zsxwing commented Jan 26, 2016

Yeah, it's because only ByteArrayInputStream/ByteArrayOutputStream is used. I think we should document that who should close the stream.

@tedyu
Copy link
Contributor Author

tedyu commented Jan 26, 2016

ERROR: Timeout after 15 minutes
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from https://github.com/apache/spark.git

@tedyu
Copy link
Contributor Author

tedyu commented Jan 26, 2016

Jenkins, test this please.

@liancheng
Copy link
Contributor

Thanks, LGTM. I'm merging this.

@asfgit asfgit closed this in fdcc351 Jan 26, 2016
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50059/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants