Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Jan 21, 2016

Clarify that modifying a driver local variable won't have the desired effect in cluster modes, and may or may not work as intended in local mode

… effect in cluster modes, and may or may not work as intended in local mode
@SparkQA
Copy link

SparkQA commented Jan 21, 2016

Test build #49877 has finished for PR 10866 at commit b62e318.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jan 23, 2016
…local vs cluster

srowen thanks for the PR at #10866! sorry it took me a while.

This is related to #10866, basically the assignment in the lambda expression in the python example is actually invalid

```
In [1]: data = [1, 2, 3, 4, 5]
In [2]: counter = 0
In [3]: rdd = sc.parallelize(data)
In [4]: rdd.foreach(lambda x: counter += x)
  File "<ipython-input-4-fcb86c182bad>", line 1
    rdd.foreach(lambda x: counter += x)
                                   ^
SyntaxError: invalid syntax
```

Author: Mortada Mehyar <[email protected]>

Closes #10867 from mortada/doc_python_fix.

(cherry picked from commit 56f57f8)
Signed-off-by: Sean Owen <[email protected]>
srowen pushed a commit to srowen/spark that referenced this pull request Jan 23, 2016
…local vs cluster

srowen thanks for the PR at apache#10866! sorry it took me a while.

This is related to apache#10866, basically the assignment in the lambda expression in the python example is actually invalid

```
In [1]: data = [1, 2, 3, 4, 5]
In [2]: counter = 0
In [3]: rdd = sc.parallelize(data)
In [4]: rdd.foreach(lambda x: counter += x)
  File "<ipython-input-4-fcb86c182bad>", line 1
    rdd.foreach(lambda x: counter += x)
                                   ^
SyntaxError: invalid syntax
```

Author: Mortada Mehyar <[email protected]>

Closes apache#10867 from mortada/doc_python_fix.
@srowen
Copy link
Member Author

srowen commented Jan 23, 2016

Merged to master/1.6

asfgit pushed a commit that referenced this pull request Jan 23, 2016
…al vs cluster mode in closure handling

Clarify that modifying a driver local variable won't have the desired effect in cluster modes, and may or may not work as intended in local mode

Author: Sean Owen <[email protected]>

Closes #10866 from srowen/SPARK-12760.

(cherry picked from commit aca2a01)
Signed-off-by: Sean Owen <[email protected]>
@asfgit asfgit closed this in aca2a01 Jan 23, 2016
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49937/
Test FAILed.

@srowen srowen deleted the SPARK-12760 branch January 25, 2016 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants