[SPARK-12921] Use SparkHadoopUtil reflection in SpecificParquetRecordReaderBase #10843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @aarondav |
|
Test build #49769 has finished for PR 10843 at commit
|
JoshRosen
force-pushed
the
SPARK-12921
branch
from
7cf0948 to
a8b3346
Compare
|
Test build #49771 has finished for PR 10843 at commit
|
…etRecordReaderBase
JoshRosen
force-pushed
the
SPARK-12921
branch
from
a8b3346 to
afd3452
Compare
Contributor
Author
|
The existing style checker didn't catch this because it only runs on Scala code, not Java files. |
|
Test build #49774 has finished for PR 10843 at commit
|
|
Test build #49779 has finished for PR 10843 at commit
|
Contributor
Author
|
Merged to branch-1.6 (1.6.1) |
asfgit
pushed a commit
that referenced
this pull request
Jan 21, 2016
…ReaderBase It looks like there's one place left in the codebase, SpecificParquetRecordReaderBase, where we didn't use SparkHadoopUtil's reflective accesses of TaskAttemptContext methods, which could create problems when using a single Spark artifact with both Hadoop 1.x and 2.x. Author: Josh Rosen <[email protected]> Closes #10843 from JoshRosen/SPARK-12921.
asfgit
pushed a commit
that referenced
this pull request
Feb 10, 2016
… SpecificParquetRecordReaderBase This is a minor followup to #10843 to fix one remaining place where we forgot to use reflective access of TaskAttemptContext methods. Author: Josh Rosen <[email protected]> Closes #11131 from JoshRosen/SPARK-12921-take-2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there's one place left in the codebase, SpecificParquetRecordReaderBase, where we didn't use SparkHadoopUtil's reflective accesses of TaskAttemptContext methods, which could create problems when using a single Spark artifact with both Hadoop 1.x and 2.x.