[SPARK-12841][SQL][branch-1.6] fix cast in filter #10819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @yhuai |
Contributor
|
Can you update the pull request description to include more information? The old pull request description is good. |
|
Test build #49633 has finished for PR 10819 at commit
|
Contributor
Author
|
retest this please |
|
Test build #49635 has finished for PR 10819 at commit
|
Contributor
|
test this please |
|
Test build #49638 has finished for PR 10819 at commit
|
Contributor
Author
|
something wrong with branch 1.6? cc @JoshRosen |
Contributor
|
There might be something wrong with that build workspace's Ivy cache. If you have Jenkins access, you should be able to SSH in and wipe it away. |
Contributor
Author
|
retest this please |
|
Test build #49655 has finished for PR 10819 at commit
|
Contributor
|
Thanks! Merging to branch 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Jan 19, 2016
In SPARK-10743 we wrap cast with `UnresolvedAlias` to give `Cast` a better alias if possible. However, for cases like filter, the `UnresolvedAlias` can't be resolved and actually we don't need a better alias for this case. This PR move the cast wrapping logic to `Column.named` so that we will only do it when we need a alias name. backport #10781 to 1.6 Author: Wenchen Fan <[email protected]> Closes #10819 from cloud-fan/bug.
Contributor
|
@cloud-fan you'd need to close this pull request yourself since it was not merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SPARK-10743 we wrap cast with
UnresolvedAliasto giveCasta better alias if possible. However, for cases like filter, theUnresolvedAliascan't be resolved and actually we don't need a better alias for this case. This PR move the cast wrapping logic toColumn.namedso that we will only do it when we need a alias name.backport #10781 to 1.6