-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-12888][SQL] benchmark the new hash expression #10816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #49621 has finished for PR 10816 at commit
|
|
retest this please |
|
I'm confused by the conclusino. We don't use UnsafeProjection anymore right? |
|
We need |
|
Test build #49629 has finished for PR 10816 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include the results as comments for each test() case?
|
LGTM |
|
we should run this benchmark again after #10809 is merged. |
|
I'm going to merge this. Please submit an update once #10809 is merged and put the result in the test case as comments. |
Benchmark it on 4 different schemas, the result: