[SPARK-12884] Move classes to their own files for readability #10810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewor14
force-pushed
the
move-things
branch
from
5bd94af to
60f026f
Compare
Contributor
Author
|
retest this please |
Contributor
|
Can you create subtasks for SPARK-10620 for your individual patches? |
Contributor
|
(Assuming you didn't change anything, LGTM). |
Contributor
|
(Same conditional LGTM from me). |
|
Test build #49605 has finished for PR 10810 at commit
|
|
Test build #49609 has finished for PR 10810 at commit
|
andrewor14
changed the title
Contributor
|
I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small step in implementing SPARK-10620, which migrates
TaskMetricsto accumulators. This patch is strictly a cleanup patch and introduces no change in functionality. It literally just moves classes to their own files to avoid having single monolithic ones that contain 10 different classes.Parent PR: #10717