Skip to content

Conversation

@dilipbiswal
Copy link
Contributor

Addresses the comments from Yin.
#10520

@dilipbiswal
Copy link
Contributor Author

@yhuai Hi Yin, i have tried to modify the other tests in this file to use withTempTable. Hopefully that is ok..

@cloud-fan
Copy link
Contributor

ok to test

@yhuai
Copy link
Contributor

yhuai commented Jan 15, 2016

can we just change that single test?

@dilipbiswal
Copy link
Contributor Author

@yhuai Sure.

@SparkQA
Copy link

SparkQA commented Jan 15, 2016

Test build #49465 has finished for PR 10758 at commit e21b5aa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor Author

@cloud-fan Can you please help trigger a retest ? Thanks !!

@cloud-fan
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Jan 15, 2016

Test build #49481 has finished for PR 10758 at commit 8f07c1e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor Author

cc @yhuai

@yhuai
Copy link
Contributor

yhuai commented Jan 18, 2016

LGTM. Thanks! Merging to master and branch 1.6.

@asfgit asfgit closed this in db9a860 Jan 18, 2016
asfgit pushed a commit that referenced this pull request Jan 18, 2016
…plied in GROUP BY clause

Addresses the comments from Yin.
#10520

Author: Dilip Biswal <[email protected]>

Closes #10758 from dilipbiswal/spark-12558-followup.

(cherry picked from commit db9a860)
Signed-off-by: Yin Huai <[email protected]>

Conflicts:
	sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants