Skip to content

[SPARK-12692][BUILD][SQL] Scala style: Fix the style violation (Space before "," or ":") #10718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-12692][BUILD][SQL] Scala style: Fix the style violation (Space before "," or ":") #10718

wants to merge 2 commits into from

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Jan 12, 2016

Fix the style violation (space before , and :).
This PR is a followup for #10643.

rxin
rxin reviewed Jan 12, 2016
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala Outdated
Copy link
Contributor

@rxin rxin Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we turn off only the specific rule

@SparkQA
Copy link

SparkQA commented Jan 12, 2016

Test build #49211 has finished for PR 10718 at commit 1de98a6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class UnsafeCartesianRDD(left: RDD[UnsafeRow], right: RDD[UnsafeRow], numFieldsOfRight: Int)
    • case class JdbcType(databaseTypeDefinition: String, jdbcNullType: Int)

@rxin
Copy link
Contributor

rxin commented Jan 12, 2016

LGTM. Let's wait till Jenkins comes back for the latest commit to merge it.

@SparkQA
Copy link

SparkQA commented Jan 12, 2016

Test build #49218 has finished for PR 10718 at commit 5ddba9d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 12, 2016

I'm going to merge this.

@asfgit asfgit closed this in 8cfa218 Jan 12, 2016
@sarutak sarutak deleted the SPARK-12692-followup-sql branch January 13, 2016 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarutak @SparkQA @rxin