[Spark-12655] [GraphX] GraphX does not unpersist RDDs #10713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
better to use
assert(sc.getPersistentRDDs.nonEmpty)
Member
|
@jasoncl I agree with this change, though I think this ends up returning RDDs that depend on other RDDs which you then unpersist before use. I agree with the comment on test style. |
|
Test build #2373 has finished for PR 10713 at commit
|
Member
|
Merged to master |
asfgit
pushed a commit
that referenced
this pull request
Jun 7, 2016
Some VertexRDD and EdgeRDD are created during the intermediate step of g.connectedComponents() but unnecessarily left cached after the method is done. The fix is to unpersist these RDDs once they are no longer in use. A test case is added to confirm the fix for the reported bug. Author: Jason Lee <[email protected]> Closes #10713 from jasoncl/SPARK-12655. (cherry picked from commit d0a5c32) Signed-off-by: Sean Owen <[email protected]>
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Jun 8, 2016
Some VertexRDD and EdgeRDD are created during the intermediate step of g.connectedComponents() but unnecessarily left cached after the method is done. The fix is to unpersist these RDDs once they are no longer in use. A test case is added to confirm the fix for the reported bug. Author: Jason Lee <[email protected]> Closes apache#10713 from jasoncl/SPARK-12655. (cherry picked from commit d0a5c32) Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 5830828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some VertexRDD and EdgeRDD are created during the intermediate step of g.connectedComponents() but unnecessarily left cached after the method is done. The fix is to unpersist these RDDs once they are no longer in use.
A test case is added to confirm the fix for the reported bug.