Skip to content

[SPARK-2118] spark class should complain if tools jar is missing. #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-2118] spark class should complain if tools jar is missing. #1068

wants to merge 2 commits into from

Conversation

@ScrapCodes
Copy link
Member

@ScrapCodes ScrapCodes commented Jun 12, 2014

No description provided.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 12, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 12, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 12, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 12, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15710/

@pwendell
Copy link
Contributor

pwendell commented Jun 12, 2014

@ScrapCodes I don't think this is what we want - because the tools jar is not required in the general case. We should only check this if the main class is GenerateMIMAIgnore.

@ScrapCodes
Copy link
Member Author

ScrapCodes commented Jun 12, 2014

Hey @pwendell this will only check for tools jar and fail if this check is true. i.e. it is one of the classes in tools sub project. Hope that is okay ?

@ScrapCodes ScrapCodes changed the title [SPARK-2118] spark class should complaing if tools jar is missing. [SPARK-2118] spark class should complain if tools jar is missing. Jun 12, 2014
@ScrapCodes
Copy link
Member Author

ScrapCodes commented Jun 16, 2014

@pwendell Did I miss anything ?

pwendell
pwendell reviewed Jun 18, 2014
View reviewed changes
bin/spark-class Outdated
Copy link
Contributor

@pwendell pwendell Jun 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just use two echo statements here? It's more consistent with the rest of this script:
https://github.com/apache/spark/pull/1068/files#diff-fdf4d3e600042c63ffa17b692c4372a3L116

Also, it will save two lines and preserve the indentation.

@pwendell
Copy link
Contributor

pwendell commented Jun 18, 2014

@ScrapCodes sorry - you are right! I just have one style comment, otherwise LGTM.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 23, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 23, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 23, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 23, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16025/

@pwendell
Copy link
Contributor

pwendell commented Jun 23, 2014

Thanks - I tested this locally and it looks good!

@asfgit asfgit closed this in 6dc6722 Jun 23, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@ScrapCodes @pdeyhim
[SPARK-2118] spark class should complain if tools jar is missing.
27bec31 
Author: Prashant Sharma <[email protected]>

Closes apache#1068 from ScrapCodes/SPARK-2118/tools-jar-check and squashes the following commits:

29e768b [Prashant Sharma] Code Review
5cb6f7d [Prashant Sharma] [SPARK-2118] spark class should complaing if tools jar is missing.
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@ScrapCodes @conviva-zz
[SPARK-2118] spark class should complain if tools jar is missing.
f623376 
Author: Prashant Sharma <[email protected]>

Closes apache#1068 from ScrapCodes/SPARK-2118/tools-jar-check and squashes the following commits:

29e768b [Prashant Sharma] Code Review
5cb6f7d [Prashant Sharma] [SPARK-2118] spark class should complaing if tools jar is missing.
@ScrapCodes ScrapCodes deleted the SPARK-2118/tools-jar-check branch June 3, 2015 06:01
wangyum pushed a commit that referenced this pull request May 26, 2023
[CARMEL-6222]Improve congestion in shuffle service (#1068)
c67115a 
* [CARMEL-6222]Improve congestion in shuffle service
udaynpusa pushed a commit to mapr/spark that referenced this pull request Jan 30, 2024
@ekrivokonmapr
MapR [SPARK-1139] Update Spark in EEP 9.1.0 to Antlr Runtime version …
411320c 
…4.9.3 (apache#1068)

Co-authored-by: Egor Krivokon <>
mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025
@ekrivokonmapr
MapR [SPARK-1139] Update Spark in EEP 9.1.0 to Antlr Runtime version …
05360cc 
…4.9.3 (apache#1068)

Co-authored-by: Egor Krivokon <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ScrapCodes @AmplabJenkins @pwendell