Skip to content

[SPARK-12701] [CORE] FileAppender should use join to ensure writing thread completion #10654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-12701] [CORE] FileAppender should use join to ensure writing thread completion #10654

wants to merge 1 commit into from

Conversation

@BryanCutler
Copy link
Member

@BryanCutler BryanCutler commented Jan 8, 2016

Changed Logging FileAppender to use join in awaitTermination to ensure that thread is properly finished before returning.

@SparkQA
Copy link

SparkQA commented Jan 8, 2016

Test build #48990 has finished for PR 10654 at commit d937d09.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Jan 8, 2016

You can also remove @volatile private var stopped = false, right?

@BryanCutler
Copy link
Member Author

BryanCutler commented Jan 8, 2016

Yeah, that variable is no longer needed - I already removed it. Did you mean @volatile private var markedForStopped? That one is still used to trigger the thread to exit.

@zsxwing
Copy link
Member

zsxwing commented Jan 8, 2016

Oh, sorry. Didn't notice that you already removed it.

@zsxwing
Copy link
Member

zsxwing commented Jan 8, 2016

LGTM. Merging to master. Thanks, @BryanCutler

@BryanCutler
Copy link
Member Author

BryanCutler commented Jan 8, 2016

No problem! Thanks @zsxwing

@asfgit asfgit closed this in ea104b8 Jan 8, 2016
asfgit pushed a commit that referenced this pull request Jan 15, 2016
@BryanCutler @srowen
[SPARK-12701][CORE] FileAppender should use join to ensure writing th…
7733668 
…read completion

Changed Logging FileAppender to use join in `awaitTermination` to ensure that thread is properly finished before returning.

Author: Bryan Cutler <[email protected]>

Closes #10654 from BryanCutler/fileAppender-join-thread-SPARK-12701.

(cherry picked from commit ea104b8)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member

srowen commented Jan 15, 2016

Also merged to 1.6

@BryanCutler BryanCutler deleted the fileAppender-join-thread-SPARK-12701 branch February 29, 2016 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BryanCutler @SparkQA @zsxwing @srowen