Skip to content

[SPARK-12673][UI] Add missing uri prepending for job description #10618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-12673][UI] Add missing uri prepending for job description #10618

wants to merge 2 commits into from

Conversation

@jerryshao
Copy link
Contributor

@jerryshao jerryshao commented Jan 6, 2016

Otherwise the url will be failed to proxy to the right one if in YARN mode. Here is the screenshot:

screen shot 2016-01-06 at 5 28 26 pm

@SparkQA
Copy link

SparkQA commented Jan 6, 2016

Test build #48849 has finished for PR 10618 at commit 7be4be0.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

jerryshao commented Jan 6, 2016

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 6, 2016

Test build #48858 has finished for PR 10618 at commit 7be4be0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

JoshRosen commented Jan 6, 2016

LGTM.

JoshRosen
JoshRosen reviewed Jan 6, 2016
View reviewed changes
core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala Outdated
Copy link
Contributor

@JoshRosen JoshRosen Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanted to clean up the code slightly, you could change this to use basePathUri defined above, then wrap it back to a single line.

Copy link
Member

@zsxwing zsxwing Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

@jerryshao jerryshao Jan 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I will change it.

@zsxwing
Copy link
Member

zsxwing commented Jan 6, 2016

Ah, didn't notice this before merging #10617. Actually, I prefer this patch since #10617 doesn't add basePath to the url. I'm going to revert it.

@zsxwing zsxwing mentioned this pull request Jan 6, 2016
Closed
asfgit pushed a commit that referenced this pull request Jan 6, 2016
@zsxwing
Revert "[SPARK-12672][STREAMING][UI] Use the uiRoot function instead …
cbaea95 
…of default root path to gain the streaming batch url."

This reverts commit 19e4e9f. Will merge #10618 instead.
asfgit pushed a commit that referenced this pull request Jan 6, 2016
@zsxwing
Revert "[SPARK-12672][STREAMING][UI] Use the uiRoot function instead …
39b0a34 
…of default root path to gain the streaming batch url."

This reverts commit 8f0ead3. Will merge #10618 instead.
asfgit pushed a commit that referenced this pull request Jan 6, 2016
@zsxwing
Revert "[SPARK-12672][STREAMING][UI] Use the uiRoot function instead …
d10b9d5 
…of default root path to gain the streaming batch url."

This reverts commit fb421af. Will merge #10618 instead.
@jerryshao
Copy link
Contributor Author

jerryshao commented Jan 7, 2016

Ahh, looks like #10617 happens to fix the same issue as this PR, I haven't noticed that one...

@SparkQA
Copy link

SparkQA commented Jan 7, 2016

Test build #48886 has finished for PR 10618 at commit 9bb0fd4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Jan 7, 2016

LGTM. Merging to master, 1.6 and 1.5

asfgit pushed a commit that referenced this pull request Jan 7, 2016
@jerryshao @zsxwing
[SPARK-12673][UI] Add missing uri prepending for job description
94af69c 
Otherwise the url will be failed to proxy to the right one if in YARN mode. Here is the screenshot:

![screen shot 2016-01-06 at 5 28 26 pm](https://cloud.githubusercontent.com/assets/850797/12139632/bbe78ecc-b49c-11e5-8932-94e8b3622a09.png)

Author: jerryshao <[email protected]>

Closes #10618 from jerryshao/SPARK-12673.

(cherry picked from commit 174e72c)
Signed-off-by: Shixiong Zhu <[email protected]>
asfgit pushed a commit that referenced this pull request Jan 7, 2016
@jerryshao @zsxwing
[SPARK-12673][UI] Add missing uri prepending for job description
f2bc02e 
Otherwise the url will be failed to proxy to the right one if in YARN mode. Here is the screenshot:

![screen shot 2016-01-06 at 5 28 26 pm](https://cloud.githubusercontent.com/assets/850797/12139632/bbe78ecc-b49c-11e5-8932-94e8b3622a09.png)

Author: jerryshao <[email protected]>

Closes #10618 from jerryshao/SPARK-12673.

(cherry picked from commit 174e72c)
Signed-off-by: Shixiong Zhu <[email protected]>
@asfgit asfgit closed this in 174e72c Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryshao @SparkQA @JoshRosen @zsxwing