Skip to content

Conversation

@cloud-fan
Copy link
Contributor

address comments in #10435

This makes the API easier to use if user programmatically generate the call to hash, and they will get analysis exception if the arguments of hash is empty.

@cloud-fan
Copy link
Contributor Author

cc @rxin

@rxin
Copy link
Contributor

rxin commented Jan 5, 2016

Can you update the error message to say "hash requires at least one argument"?

@rxin
Copy link
Contributor

rxin commented Jan 5, 2016

LGTM

@rxin
Copy link
Contributor

rxin commented Jan 5, 2016

Oh - we need to add a version for python too...

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48743 has finished for PR 10588 at commit 9c72e01.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48736 has finished for PR 10588 at commit ba303fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48741 has finished for PR 10588 at commit b652b45.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48750 has finished for PR 10588 at commit f3a557b.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48758 has finished for PR 10588 at commit 9e05b1e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 5, 2016

Thanks - I've merged this.

@asfgit asfgit closed this in 7676833 Jan 5, 2016
@cloud-fan cloud-fan deleted the hash branch January 6, 2016 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants