Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Jan 4, 2016

This patch added Py4jCallbackConnectionCleaner to clean the leak sockets of Py4J every 30 seconds. This is a workaround before Py4J fixes the leak issue py4j/py4j#187

@zsxwing
Copy link
Member Author

zsxwing commented Jan 4, 2016

CC @davies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is not called because PySpark never stops the gateway server.

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48700 has finished for PR 10579 at commit bfd1b9a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48691 has finished for PR 10579 at commit 950d5d0.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Py4jCallbackConnectionCleaner(object):

@zsxwing
Copy link
Member Author

zsxwing commented Jan 5, 2016

retest this please

@SparkQA
Copy link

SparkQA commented Jan 5, 2016

Test build #48710 has finished for PR 10579 at commit bfd1b9a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Jan 5, 2016

LGTM

asfgit pushed a commit that referenced this pull request Jan 5, 2016
This patch added Py4jCallbackConnectionCleaner to clean the leak sockets of Py4J every 30 seconds. This is a workaround before Py4J fixes the leak issue py4j/py4j#187

Author: Shixiong Zhu <[email protected]>

Closes #10579 from zsxwing/SPARK-12617.

(cherry picked from commit 047a31b)
Signed-off-by: Davies Liu <[email protected]>
asfgit pushed a commit that referenced this pull request Jan 5, 2016
This patch added Py4jCallbackConnectionCleaner to clean the leak sockets of Py4J every 30 seconds. This is a workaround before Py4J fixes the leak issue py4j/py4j#187

Author: Shixiong Zhu <[email protected]>

Closes #10579 from zsxwing/SPARK-12617.

(cherry picked from commit 047a31b)
Signed-off-by: Davies Liu <[email protected]>
@davies
Copy link
Contributor

davies commented Jan 5, 2016

Merged into master and 1.5, 1.6 branch

@asfgit asfgit closed this in 047a31b Jan 5, 2016
@zsxwing zsxwing deleted the SPARK-12617 branch January 5, 2016 22:02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traceback (most recent call last):
File "//anaconda/lib/python2.7/threading.py", line 810, in __bootstrap_inner
self.run()
File "//anaconda/lib/python2.7/threading.py", line 1082, in run
self.function(_self.args, *_self.kwargs)
File "/Users/davies/work/spark/python/pyspark/context.py", line 78, in clean_closed_connections
with callback_server.lock:
AttributeError: 'NoneType' object has no attribute 'lock'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I didn't notice that only Streaming uses the callback server. I sent #10621 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants