-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-12617][PySpark]Clean up the leak sockets of Py4J #10579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CC @davies |
python/pyspark/context.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is not called because PySpark never stops the gateway server.
|
Test build #48700 has finished for PR 10579 at commit
|
|
Test build #48691 has finished for PR 10579 at commit
|
|
retest this please |
|
Test build #48710 has finished for PR 10579 at commit
|
|
LGTM |
This patch added Py4jCallbackConnectionCleaner to clean the leak sockets of Py4J every 30 seconds. This is a workaround before Py4J fixes the leak issue py4j/py4j#187 Author: Shixiong Zhu <[email protected]> Closes #10579 from zsxwing/SPARK-12617. (cherry picked from commit 047a31b) Signed-off-by: Davies Liu <[email protected]>
This patch added Py4jCallbackConnectionCleaner to clean the leak sockets of Py4J every 30 seconds. This is a workaround before Py4J fixes the leak issue py4j/py4j#187 Author: Shixiong Zhu <[email protected]> Closes #10579 from zsxwing/SPARK-12617. (cherry picked from commit 047a31b) Signed-off-by: Davies Liu <[email protected]>
|
Merged into master and 1.5, 1.6 branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traceback (most recent call last):
File "//anaconda/lib/python2.7/threading.py", line 810, in __bootstrap_inner
self.run()
File "//anaconda/lib/python2.7/threading.py", line 1082, in run
self.function(_self.args, *_self.kwargs)
File "/Users/davies/work/spark/python/pyspark/context.py", line 78, in clean_closed_connections
with callback_server.lock:
AttributeError: 'NoneType' object has no attribute 'lock'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I didn't notice that only Streaming uses the callback server. I sent #10621 to fix it.
This patch added Py4jCallbackConnectionCleaner to clean the leak sockets of Py4J every 30 seconds. This is a workaround before Py4J fixes the leak issue py4j/py4j#187