Skip to content

[SPARK-12461] [SQL] Add ExpressionDescription to math functions #10489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-12461] [SQL] Add ExpressionDescription to math functions #10489

wants to merge 3 commits into from

Conversation

@vectorijk
Copy link
Contributor

@vectorijk vectorijk commented Dec 27, 2015

cc @yhuai

@SparkQA
Copy link

SparkQA commented Dec 27, 2015

Test build #48351 has finished for PR 10489 at commit 6c1d8b5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell hvanhovell mentioned this pull request Dec 27, 2015
Closed
@SparkQA
Copy link

SparkQA commented Dec 28, 2015

Test build #48359 has finished for PR 10489 at commit e31723d.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vectorijk
update according to apache#10488
12d129d 
switch some usage in ExpressionDescription to raw string literal
@SparkQA
Copy link

SparkQA commented Dec 28, 2015

Test build #48360 has finished for PR 10489 at commit 12d129d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Dec 28, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala Outdated
Copy link
Contributor

@rxin rxin Dec 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space after -

@SparkQA
Copy link

SparkQA commented Dec 29, 2015

Test build #48411 has finished for PR 10489 at commit 1c96229.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vectorijk
Copy link
Contributor Author

vectorijk commented Apr 1, 2016

I will close this PR at this time. If needed, I might re-open this.

@vectorijk vectorijk closed this Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vectorijk @SparkQA @rxin