Skip to content

[SPARK-12380] [PYSPARK] use SQLContext.getOrCreate in mllib #10338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-12380] [PYSPARK] use SQLContext.getOrCreate in mllib #10338

wants to merge 2 commits into from

Conversation

@davies
Copy link
Contributor

@davies davies commented Dec 16, 2015

MLlib should use SQLContext.getOrCreate() instead of creating new SQLContext.

jkbradley
jkbradley reviewed Dec 16, 2015
View reviewed changes
python/pyspark/mllib/feature.py Outdated
Copy link
Member

@jkbradley jkbradley Dec 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, sc is not even used here, so it could be removed.

@jkbradley
Copy link
Member

jkbradley commented Dec 16, 2015

To confirm: There is no need to use getOrCreate in tests, right?

The other changes look fine.

@davies
Copy link
Contributor Author

davies commented Dec 16, 2015

@jkbradley For tests, they are fine.

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47859 has finished for PR 10338 at commit 9ae9bd4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

jkbradley commented Dec 16, 2015

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47865 has finished for PR 10338 at commit 518e37c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Dec 16, 2015
@davies
[SPARK-12380] [PYSPARK] use SQLContext.getOrCreate in mllib
552b38f 
MLlib should use SQLContext.getOrCreate() instead of creating new SQLContext.

Author: Davies Liu <[email protected]>

Closes #10338 from davies/create_context.

(cherry picked from commit 27b98e9)
Signed-off-by: Davies Liu <[email protected]>
@asfgit asfgit closed this in 27b98e9 Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davies @jkbradley @SparkQA