Skip to content

[Minor] Add missing interpolation in NettyRPCEnv #10334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Minor] Add missing interpolation in NettyRPCEnv #10334

wants to merge 1 commit into from

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Dec 16, 2015 

Exception in thread "main" org.apache.spark.rpc.RpcTimeoutException:
Cannot receive any reply in ${timeout.duration}. This timeout is controlled by spark.rpc.askTimeout
    at org.apache.spark.rpc.RpcTimeout.org$apache$spark$rpc$RpcTimeout$$createRpcTimeoutException(RpcTimeout.scala:48)
    at org.apache.spark.rpc.RpcTimeout$$anonfun$addMessageIfTimeout$1.applyOrElse(RpcTimeout.scala:63)
    at org.apache.spark.rpc.RpcTimeout$$anonfun$addMessageIfTimeout$1.applyOrElse(RpcTimeout.scala:59)
    at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:33)

@zsxwing
Copy link
Member

zsxwing commented Dec 16, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47842 has finished for PR 10334 at commit a853e63.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Dec 16, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47857 has finished for PR 10334 at commit a853e63.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Dec 17, 2015

Merging to master and 1.6

@asfgit asfgit closed this in 861549a Dec 17, 2015
asfgit pushed a commit that referenced this pull request Dec 17, 2015
@zsxwing
[MINOR] Add missing interpolation in NettyRPCEnv
638b89b 
```
Exception in thread "main" org.apache.spark.rpc.RpcTimeoutException:
Cannot receive any reply in ${timeout.duration}. This timeout is controlled by spark.rpc.askTimeout
	at org.apache.spark.rpc.RpcTimeout.org$apache$spark$rpc$RpcTimeout$$createRpcTimeoutException(RpcTimeout.scala:48)
	at org.apache.spark.rpc.RpcTimeout$$anonfun$addMessageIfTimeout$1.applyOrElse(RpcTimeout.scala:63)
	at org.apache.spark.rpc.RpcTimeout$$anonfun$addMessageIfTimeout$1.applyOrElse(RpcTimeout.scala:59)
	at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:33)
```

Author: Andrew Or <[email protected]>

Closes #10334 from andrewor14/rpc-typo.

(cherry picked from commit 861549a)
Signed-off-by: Shixiong Zhu <[email protected]>
@andrewor14 andrewor14 deleted the rpc-typo branch December 17, 2015 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewor14 @zsxwing @SparkQA