[SPARK-12231][SQL]create a combineFilters' projection when we call buildPartitionedTableScan #10299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
We use use an AttributeSet anytime we are dealing with AttributeReference objects.
Contributor
|
ok to test |
|
Test build #47682 has finished for PR 10299 at commit
|
Contributor
Author
|
Hello Michael: I fixed the scala style issue, can you help re-run the test? Thanks. |
Contributor
|
ok to test |
|
Test build #47690 has finished for PR 10299 at commit
|
|
Test build #47691 has finished for PR 10299 at commit
|
Contributor
Author
|
The failure is because of the changed project, will submit an updated patch tomorrow. |
Contributor
Author
|
I will create a new PR. |
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Dec 28, 2015
…uildPartitionedTableScan Hello Michael & All: We have some issues to submit the new codes in the other PR(apache#10299), so we closed that PR and open this one with the fix. The reason for the previous failure is that the projection for the scan when there is a filter that is not pushed down (the "left-over" filter) could be different, in elements or ordering, from the original projection. With this new codes, the approach to solve this problem is: Insert a new Project if the "left-over" filter is nonempty and (the original projection is not empty and the projection for the scan has more than one elements which could otherwise cause different ordering in projection). We create 3 test cases to cover the otherwise failure cases. Author: Kevin Yu <[email protected]> Closes apache#10388 from kevinyu98/spark-12231.
asfgit
pushed a commit
that referenced
this pull request
Feb 1, 2016
…uildPartitionedTableScan Hello Michael & All: We have some issues to submit the new codes in the other PR(#10299), so we closed that PR and open this one with the fix. The reason for the previous failure is that the projection for the scan when there is a filter that is not pushed down (the "left-over" filter) could be different, in elements or ordering, from the original projection. With this new codes, the approach to solve this problem is: Insert a new Project if the "left-over" filter is nonempty and (the original projection is not empty and the projection for the scan has more than one elements which could otherwise cause different ordering in projection). We create 3 test cases to cover the otherwise failure cases. Author: Kevin Yu <[email protected]> Closes #10388 from kevinyu98/spark-12231. (cherry picked from commit fd50df4) Signed-off-by: Cheng Lian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Michael & All: Here I am submitting another approach to solve this problem. Can you verify ?
I think the problem is related to change from spark-10829,
before that PR change, the projects and filters are done inside buildPartitionedTableScan.
With that PR change, the filter expression divide to 3 parts, the filter left outside of the scan (combineFilters ) needs a different projection.
So the fix is to create a combine projection for the outside filter and beyond.
Thanks for your comments.