[SPARK-12057] [SQL] Prevent failure on corrupt JSON records #10288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@simplyianm @srowen I create this PR based on #10043. Please see yhuai@d8722bb for my change. This PR should fix the test. It also makes the schema inference more robust to records that we cannot parse. |
|
Test build #47641 has finished for PR 10288 at commit
|
|
Test build #47646 has finished for PR 10288 at commit
|
Contributor
There was a problem hiding this comment.
Should the other error cases be handled this way too? The String -> float/double conversions.
Contributor
Author
There was a problem hiding this comment.
yeah, it is a good point. I added the change.
Return failed record when a record cannot be parsed. Allows parsing of files containing corrupt records of any form.
|
Test build #47863 has finished for PR 10288 at commit
|
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
this should technically extend RuntimeException
Contributor
|
I'm going to merge this into master & branch-1.6. |
asfgit
pushed a commit
that referenced
this pull request
Dec 17, 2015
This PR makes JSON parser and schema inference handle more cases where we have unparsed records. It is based on #10043. The last commit fixes the failed test and updates the logic of schema inference. Regarding the schema inference change, if we have something like ``` {"f1":1} [1,2,3] ``` originally, we will get a DF without any column. After this change, we will get a DF with columns `f1` and `_corrupt_record`. Basically, for the second row, `[1,2,3]` will be the value of `_corrupt_record`. When merge this PR, please make sure that the author is simplyianm. JIRA: https://issues.apache.org/jira/browse/SPARK-12057 Closes #10043 Author: Ian Macalinao <[email protected]> Author: Yin Huai <[email protected]> Closes #10288 from yhuai/handleCorruptJson. (cherry picked from commit 9d66c42) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes JSON parser and schema inference handle more cases where we have unparsed records. It is based on #10043. The last commit fixes the failed test and updates the logic of schema inference.
Regarding the schema inference change, if we have something like
originally, we will get a DF without any column.
After this change, we will get a DF with columns
f1and_corrupt_record. Basically, for the second row,[1,2,3]will be the value of_corrupt_record.When merge this PR, please make sure that the author is @simplyianm.
JIRA: https://issues.apache.org/jira/browse/SPARK-12057
Closes #10043