[SPARK-12314][SQL] isnull operator not pushed down for JDBC datasource. #10286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
changed the title
Member
Author
|
Actually the test for this PR is not correctly being tested with the result but I just added it just like the other predicate tests. I will correct the test as soon as #10221 is merged. |
|
Test build #47635 has finished for PR 10286 at commit
|
Member
Author
|
I updated the test for this since #10221 is merged. |
|
Test build #47784 has finished for PR 10286 at commit
|
Member
Author
|
cc @rxin |
Contributor
|
I've merged this into master. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-12314
IsNullfilter is not being pushed down for JDBC datasource.It looks it is SQL standard according to SQL-92, SQL:1999, SQL:2003 and SQL:201x and I believe most databases support this.
In this PR, I simply added the case for
IsNullfilter to produce a proper filter string.