-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[Streaming][Doc][Minor] Update the description of direct Kafka stream doc #10246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #47490 has finished for PR 10246 at commit
|
|
LGTM |
|
Thanks @jerryshao. Merging to master, 1.6, 1.5, 1.4. |
… doc With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise. zsxwing tdas , please review, thanks a lot. Author: jerryshao <[email protected]> Closes #10246 from jerryshao/direct-kafka-doc-update. (cherry picked from commit 24d3357) Signed-off-by: Shixiong Zhu <[email protected]>
… doc With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise. zsxwing tdas , please review, thanks a lot. Author: jerryshao <[email protected]> Closes #10246 from jerryshao/direct-kafka-doc-update. (cherry picked from commit 24d3357) Signed-off-by: Shixiong Zhu <[email protected]>
… doc With the merge of [SPARK-8337](https://issues.apache.org/jira/browse/SPARK-8337), now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise. zsxwing tdas , please review, thanks a lot. Author: jerryshao <[email protected]> Closes #10246 from jerryshao/direct-kafka-doc-update. (cherry picked from commit 24d3357) Signed-off-by: Shixiong Zhu <[email protected]>
|
Hi @zsxwing, one of the feature "message handler" is only supported in 1.6. So maybe better not merge back to the previous version :). |
Is |
|
No, it is not mentioned in the doc. What I mean is that for previous version, Python api still miss this piece of functionality, so correcting this description in the previous version is not exactly correct. |
|
But it will be confusing if we say We don't mention if we support a custom message handler in the doc. Even if Python api didn't support the message handler in 1.4 and 1.5, we can still say Python api supports the Kafka direct stream. Right? |
With the merge of SPARK-8337, now the Python API has the same functionalities compared to Scala/Java, so here changing the description to make it more precise.
@zsxwing @tdas , please review, thanks a lot.