Skip to content

Conversation

@HyukjinKwon
Copy link
Member

https://issues.apache.org/jira/browse/SPARK-12249
Currently != operator is not pushed down correctly.
I simply added a case for this.

@HyukjinKwon
Copy link
Member Author

Several things to mention.

Firstly, I did not add the tests for it yet because pushed down filters are not correctly tested at the original test codes. I will add as soon as #10221 is merged.

Secondly, I just opened this PR without asking if it is really supposed to be supported. This is because I see the test codes intended to check this operator (which is not testing properly) and also I don't think there is any database not supporting this operator as it is a SQL Standard.

Lastly I tested this by adding a test locally with #10221.

@HyukjinKwon HyukjinKwon changed the title [SPARK-12249][SQL] JDBC not-equality comparison operator not pushed down. [SPARK-12249][SQL] JDBC non-equality comparison operator not pushed down. Dec 10, 2015
@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #47459 has finished for PR 10233 at commit 6cdd5f3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

I updated the test for this since #10221 is merged.

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47779 has finished for PR 10233 at commit 33f67e7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class WrapOption(child: Expression, optType: DataType)\n

@HyukjinKwon
Copy link
Member Author

cc @rxin

@rxin
Copy link
Contributor

rxin commented Dec 16, 2015

Thanks - I've merged this into master.

@asfgit asfgit closed this in 0f6936b Dec 16, 2015
zzcclp added a commit to zzcclp/spark that referenced this pull request Jul 27, 2016
@HyukjinKwon HyukjinKwon deleted the SPARK-12249 branch September 23, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants