Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Dec 8, 2015

Fix commons-collection group ID to commons-collections for version 3.x

Patches earlier PR at #9731

@XuTingjun
Copy link
Contributor

LGTM, thanks

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #2180 has finished for PR 10198 at commit 6711c9c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Dec 8, 2015

I'm going to merge this shortly as a sort of 'hot fix', though it doesn't fix anything -- the original PR was an improvement but didn't actually have an effect.

asfgit pushed a commit that referenced this pull request Dec 8, 2015
Fix commons-collection group ID to commons-collections for version 3.x

Patches earlier PR at #9731

Author: Sean Owen <[email protected]>

Closes #10198 from srowen/SPARK-11652.2.

(cherry picked from commit e3735ce)
Signed-off-by: Sean Owen <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 8, 2015
Fix commons-collection group ID to commons-collections for version 3.x

Patches earlier PR at #9731

Author: Sean Owen <[email protected]>

Closes #10198 from srowen/SPARK-11652.2.

(cherry picked from commit e3735ce)
Signed-off-by: Sean Owen <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 8, 2015
Fix commons-collection group ID to commons-collections for version 3.x

Patches earlier PR at #9731

Author: Sean Owen <[email protected]>

Closes #10198 from srowen/SPARK-11652.2.

(cherry picked from commit e3735ce)
Signed-off-by: Sean Owen <[email protected]>
@asfgit asfgit closed this in e3735ce Dec 8, 2015
@JoshRosen
Copy link
Contributor

Hey, quick Q.: how do we make sure that the bad version of the dependency (under a different org / artifact ID) doesn't get pulled in transitively and wind up taking precedence (e.g. in an assembly JAR)? Should we use the Maven Enforcer plugin or something to ban that older dependency?

@srowen
Copy link
Member Author

srowen commented Dec 9, 2015

@JoshRosen there's only only group/artifact for Commons Collections <= 3.x; 4.x uses the new group but doesn't have the problem. This should force the dependency on commons-collections to resolve to 3.2.2 by managing any other version up. It shouldn't be necessary to look for other versions as they're overridden by this declaration.

@srowen srowen deleted the SPARK-11652.2 branch December 9, 2015 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants