Skip to content

[SPARK-12186] [WEB UI] Send the complete request URI including the query string when redirecting. #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-12186] [WEB UI] Send the complete request URI including the query string when redirecting. #10180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7625c88
SPARK-12186: Send the complete request URI including the query string…
Dec 7, 2015
780ee62
SPARK-12186: Add a comment explaining the changes. Convert it to a on…
Dec 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ class HistoryServer(
// Note we don't use the UI retrieved from the cache; the cache loader above will register
// the app's UI, and all we need to do is redirect the user to the same URI that was
// requested, and the proper data should be served at that point.
Copy link
Contributor

@andrewor14 andrewor14 Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expand on this comment, summarizing SPARK-12186 in 1 sentence?

Copy link
Contributor Author

@rohitagarwal003 rohitagarwal003 Dec 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

res.sendRedirect(res.encodeRedirectURL(req.getRequestURI()))
// Also, make sure that the redirect url contains the query string present in the request.
val requestURI = req.getRequestURI + Option(req.getQueryString).map("?" + _).getOrElse("")
res.sendRedirect(res.encodeRedirectURL(requestURI))
}

// SPARK-5983 ensure TRACE is not supported
Expand Down