Skip to content

Conversation

@JoshRosen
Copy link
Contributor

Currently, dev/scalastyle invokes SBT four times, but these invocations can be replaced with a single invocation, saving about one minute of build time.

@vanzin
Copy link
Contributor

vanzin commented Dec 4, 2015

I have code in #6502 to keep the scalastyle.txt file around (so we can look at warnings). Both changes will conflict in any case, but it would be nice to have the complete output available.

@JoshRosen
Copy link
Contributor Author

@vanzin, what about just running sbt/sbt scalastyle by hand if you want to inspect the log output?

@vanzin
Copy link
Contributor

vanzin commented Dec 4, 2015

Either way. It just seems nice to keep the whole output around when it's so cheap to do it.

@SparkQA
Copy link

SparkQA commented Dec 5, 2015

Test build #47209 has finished for PR 10151 at commit 9de4d4c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public abstract static class PrefixComputer\n

@JoshRosen
Copy link
Contributor Author

We can handle retention of the output in a followup, since it'd probably be best to also do it for Java, Python, and R style checks. Therefore, I'm going to merge this now.

@asfgit asfgit closed this in 80a824d Dec 7, 2015
@JoshRosen JoshRosen deleted the speed-up-scalastyle branch December 7, 2015 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants