Skip to content

Conversation

@tdas
Copy link
Contributor

@tdas tdas commented Dec 3, 2015

No description provided.

@tdas
Copy link
Contributor Author

tdas commented Dec 3, 2015

@zsxwing Please take a look. Most of the change is in indentation.

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #47128 has finished for PR 10124 at commit a66723e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor Author

tdas commented Dec 3, 2015

@zsxwing Please merge this to older branches if possible.

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #2156 has finished for PR 10124 at commit a66723e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #2157 has finished for PR 10124 at commit a66723e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

Diff minus whitespace changes: https://github.com/apache/spark/pull/10124/files?w=0

@zsxwing
Copy link
Member

zsxwing commented Dec 3, 2015

This one doesn't fix the flaky test. Instead, it just makes sure StreamingContexts will be shutdown if the tests fail. Right?

@tdas
Copy link
Contributor Author

tdas commented Dec 3, 2015

It is kindof. One test failure, would cause many subsequent tests to fail. So it is a fix for flakiness of the subsequent tests in the suite :)

@zsxwing
Copy link
Member

zsxwing commented Dec 3, 2015

LGTM

asfgit pushed a commit that referenced this pull request Dec 3, 2015
…tdown after test

Author: Tathagata Das <[email protected]>

Closes #10124 from tdas/InputStreamSuite-flaky-test.

(cherry picked from commit a02d472)
Signed-off-by: Tathagata Das <[email protected]>
@asfgit asfgit closed this in a02d472 Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants