Skip to content

Conversation

@microwishing
Copy link
Contributor

this is to fix some typo in external/kafka/src/main/scala/org/apache/spark/streaming/kafka/OffsetRange.scala

@microwishing microwishing changed the title [DOC]fix typo [DOCUMENTATION]fix typo Dec 3, 2015
@microwishing microwishing changed the title [DOCUMENTATION]fix typo [DOCUMENTATION][KAFKA] fix typo in kafka/OffsetRange.scala Dec 3, 2015
@srowen
Copy link
Member

srowen commented Dec 3, 2015

@microwishing can you have a look at the rest of the doc around this for any other typos? even small PRs have nonzero overhead, so I'm encouraging people to not just open a PR for single typos as they see them, but take a little time, if they're bothering, to evaluate similar issues around the change. Maybe there aren't any.

@microwishing
Copy link
Contributor Author

@srowen thanks for your tips. I happened to work on some kafka project recently so I went through source codes including comments for spark kafka streaming part today.

I spent some time setting up the spark dev environment and feel good so far due to rich doc. Those are indeed trivial typos. I can make check-ins next time after fixing some real bugs here.

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #2163 has finished for PR 10121 at commit 97dfb8b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Dec 3, 2015

Merged to master/1.6

@asfgit asfgit closed this in 95b3cf1 Dec 3, 2015
asfgit pushed a commit that referenced this pull request Dec 3, 2015
this is to fix some typo in external/kafka/src/main/scala/org/apache/spark/streaming/kafka/OffsetRange.scala

Author: microwishing <[email protected]>

Closes #10121 from microwishing/master.

(cherry picked from commit 95b3cf1)
Signed-off-by: Sean Owen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants