[SPARK-12114][SQL]Bug fix for Column Pruning rule failure in case of "Project<-Filter<-Join" #10117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
Is it a problem for all operators under Filter? like Project<-Filter<-Join, Project<-Filter<-Aggregate, Project<-Filter<-Sort, etc.
Author
There was a problem hiding this comment.
I think this problem shouldn't occur in Aggregate since it's covered by the pattern match:
case a @ Aggregate(,,child) if (child.outputSet -- a.references).nonempty.
As for Sort, I still need to think it over.
Contributor
|
I believe this problem has been fixed in 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the failure of Column Pruning rule when there is pattern "Project<-Filter<-Join" in the logical plan.