Skip to content

[SPARK-12000] do not specify arg types when reference a method in ScalaDoc #10114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-12000] do not specify arg types when reference a method in ScalaDoc #10114

wants to merge 1 commit into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Dec 3, 2015

This fixes SPARK-12000, verified on my local with JDK 7. It seems that scaladoc try to match method names and messed up with annotations.

cc: @JoshRosen @jkbradley

@mengxr mengxr mentioned this pull request Dec 3, 2015
Closed
@JoshRosen
Copy link
Contributor

JoshRosen commented Dec 3, 2015

LGTM. I tested locally and can confirm that this fixes the issue.

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #47098 has finished for PR 10114 at commit fbd83b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class CrossValidator @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String)\n * class ParamGridBuilder @Since(\"1.2.0\")\n * class TrainValidationSplit @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n

asfgit pushed a commit that referenced this pull request Dec 3, 2015
@mengxr
[SPARK-12000] do not specify arg types when reference a method in Sca…
656d44e 
…laDoc

This fixes SPARK-12000, verified on my local with JDK 7. It seems that `scaladoc` try to match method names and messed up with annotations.

cc: JoshRosen jkbradley

Author: Xiangrui Meng <[email protected]>

Closes #10114 from mengxr/SPARK-12000.2.

(cherry picked from commit 9bb695b)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 9bb695b Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mengxr @JoshRosen @SparkQA