-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-12107] [EC2] Update spark-ec2 versions #10109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ec2/spark_ec2.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this mapping. I'm just assuming that a version of Tachyon that works with 1.5.0 will also work with later versions. @haoyuan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWI we're now depending on Tachyon 0.8.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting with Spark 1.6.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
JIRA please. This is how we track things to make sure they get merged before RCs are cut. |
|
👌 |
|
Done. |
|
Test build #47087 has finished for PR 10109 at commit
|
b67767f to
8da0bfe
Compare
|
Test build #47101 has finished for PR 10109 at commit
|
|
LGTM. Merging this. Thanks @nchammas |
|
Well there is one issue here. The launch will fail for users on master, branch-1.6 until the 1.6.0 tar balls are available on S3. I am not sure there is a nice way around this. Thoughts ? |
|
What have we done in the past in this situation? People running on master can get around this by manually specifying the Spark version with |
|
I think in the past our approach has been
This is obviously very cumbersome (especially step 2 ?) and I'm not sure if @pwendell has any scripts which automate the release step especially. |
|
If it helps simplify things, why don't we immediately merge in this change to both master and branch-1.6, and simply ask people to use I think it's reasonable to expect people running on the bleeding edge to deal with really minor annoyances like this if means making life easier for the maintainers. |
|
Alright I'm fine with merging this since (a) we are pretty close to the release and (b) we should try to pull out spark_ec2.py from the apache repo to avoid this for the 2.0 release. |
I haven't created a JIRA. If we absolutely need one I'll do it, but I'm fine with not getting mentioned in the release notes if that's the only purpose it'll serve. cc marmbrus - We should include this in 1.6-RC2 if there is one. I can open a second PR against branch-1.6 if necessary. Author: Nicholas Chammas <[email protected]> Closes #10109 from nchammas/spark-ec2-versions. (cherry picked from commit ad7cea6) Signed-off-by: Shivaram Venkataraman <[email protected]>
|
👍 |
I haven't created a JIRA. If we absolutely need one I'll do it, but I'm fine with not getting mentioned in the release notes if that's the only purpose it'll serve.
cc @marmbrus - We should include this in 1.6-RC2 if there is one. I can open a second PR against branch-1.6 if necessary.