Skip to content

Conversation

@andrewor14
Copy link
Contributor

Garbage collection triggers cleanups. If the driver JVM is huge and there is little memory pressure, we may never clean up shuffle files on executors. This is a problem for long-running applications (e.g. streaming).

@andrewor14
Copy link
Contributor Author

@tdas @JoshRosen

@SparkQA
Copy link

SparkQA commented Dec 1, 2015

Test build #46976 has finished for PR 10070 at commit c96d5e2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * * For example, we build an encoder forcase class Data(a: Int, b: String)and the real type\n * case class UpCast(child: Expression, dataType: DataType, walkedTypePath: Seq[String])\n * case class InitializeJavaBean(beanInstance: Expression, setters: Map[String, Expression])\n

@andrewor14
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Dec 1, 2015

Test build #46993 has finished for PR 10070 at commit c96d5e2.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

retest this please

@JoshRosen
Copy link
Contributor

After this change, do you think that there's any chance that we could deprecate the somewhat unsafe spark.cleaner.ttl parameter? Should we update the docs to reflect this new parameter and suggest that spark.cleaner.ttl should no longer need to be set? Also fine to do that separately, but just wondering.

@andrewor14
Copy link
Contributor Author

Let's do that separately

@JoshRosen
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Dec 2, 2015

Test build #47015 has finished for PR 10070 at commit c96d5e2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 2, 2015

Test build #2143 has finished for PR 10070 at commit c96d5e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

LGTM, so I'm going to merge this into master and branch-1.6.

@SparkQA
Copy link

SparkQA commented Dec 2, 2015

Test build #2145 has finished for PR 10070 at commit c96d5e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Dec 2, 2015
Garbage collection triggers cleanups. If the driver JVM is huge and there is little memory pressure, we may never clean up shuffle files on executors. This is a problem for long-running applications (e.g. streaming).

Author: Andrew Or <[email protected]>

Closes #10070 from andrewor14/periodic-gc.

(cherry picked from commit 1ce4adf)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 1ce4adf Dec 2, 2015
@SparkQA
Copy link

SparkQA commented Dec 2, 2015

Test build #2144 has finished for PR 10070 at commit c96d5e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants