[SPARK-12075][SQL] Speed up HiveComparisionTest by avoiding / speeding up TestHive.reset() #10055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #46934 has finished for PR 10055 at commit
|
|
Test build #46947 has finished for PR 10055 at commit
|
|
Test build #46955 has finished for PR 10055 at commit
|
|
Test build #46956 has finished for PR 10055 at commit
|
Contributor
|
I like this idea. How many queries to we have to retry? Should we cache that? |
Contributor
Author
|
AFAIK it currently doesn't need to retry any queries, since the current set of heuristics for determining when / whether to reset() seems to be working well. |
JoshRosen
changed the title
Contributor
Author
|
I've created a JIRA for this and have updated the PR title and description; PTAL. |
Contributor
Author
|
Update: it looks like only one query needed to be retried: Since things seem to be running quickly, I'm inclined to skip the caching of the |
|
Test build #46979 has finished for PR 10055 at commit
|
Contributor
|
LGTM - merging this in master and branch-1.6. |
asfgit
pushed a commit
that referenced
this pull request
Dec 1, 2015
…g up TestHive.reset() When profiling HiveCompatibilitySuite, I noticed that most of the time seems to be spent in expensive `TestHive.reset()` calls. This patch speeds up suites based on HiveComparisionTest, such as HiveCompatibilitySuite, with the following changes: - Avoid `TestHive.reset()` whenever possible: - Use a simple set of heuristics to guess whether we need to call `reset()` in between tests. - As a safety-net, automatically re-run failed tests by calling `reset()` before the re-attempt. - Speed up the expensive parts of `TestHive.reset()`: loading the `src` and `srcpart` tables took roughly 600ms per test, so we now avoid this by using a simple heuristic which only loads those tables by tests that reference them. This is based on simple string matching over the test queries which errs on the side of loading in more situations than might be strictly necessary. After these changes, HiveCompatibilitySuite seems to run in about 10 minutes. This PR is a revival of #6663, an earlier experimental PR from June, where I played around with several possible speedups for this suite. Author: Josh Rosen <[email protected]> Closes #10055 from JoshRosen/speculative-testhive-reset. (cherry picked from commit ef6790f) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling HiveCompatibilitySuite, I noticed that most of the time seems to be spent in expensive
TestHive.reset()calls. This patch speeds up suites based on HiveComparisionTest, such as HiveCompatibilitySuite, with the following changes:TestHive.reset()whenever possible:reset()in between tests.reset()before the re-attempt.TestHive.reset(): loading thesrcandsrcparttables took roughly 600ms per test, so we now avoid this by using a simple heuristic which only loads those tables by tests that reference them. This is based on simple string matching over the test queries which errs on the side of loading in more situations than might be strictly necessary.After these changes, HiveCompatibilitySuite seems to run in about 10 minutes.
This PR is a revival of #6663, an earlier experimental PR from June, where I played around with several possible speedups for this suite.