Skip to content

Conversation

@JoshRosen
Copy link
Contributor

This commit upgrades the Tachyon dependency from 0.8.1 to 0.8.2.

@JoshRosen
Copy link
Contributor Author

/cc @calvinjia

@calvinjia
Copy link
Contributor

@JoshRosen
LGTM, thanks for updating this.

@SparkQA
Copy link

SparkQA commented Dec 1, 2015

Test build #46933 has finished for PR 10054 at commit e5ecbe0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 1, 2015

Test build #46944 has finished for PR 10054 at commit e5ecbe0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, quick question: why do we need these exclusions? AFAIK tachyon-client is an uber-JAR which shades all of its dependencies: http://mvnrepository.com/artifact/org.tachyonproject/tachyon-client/0.8.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I guess we need this because the tachyon-client JAR still declares compile-scope dependencies on the artifacts that it shades and relocates, which will result in Tachyon client's shaded dependencies being pulled in. I'm a bit confused about why the tachyon-client JAR is published with a non-dependency-reduced POM.

This is corroborated by #8577, which needed to add additional exclusions because of this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've filed https://tachyon.atlassian.net/browse/TACHYON-1380 to ask Tachyon to change the handling of dependencies in this POM for future releases. For now, though, I've verified that we don't need to change any of these exclusions because the client's dependencies haven't changed, so I think this PR should be good to merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there was some slight confusion here: I somehow parsed "Distribution of Tachyon client module with shaded packages in jar" as "shades all dependencies", which isn't true, so there's not an issue here. My bad.

asfgit pushed a commit that referenced this pull request Dec 1, 2015
This commit upgrades the Tachyon dependency from 0.8.1 to 0.8.2.

Author: Josh Rosen <[email protected]>

Closes #10054 from JoshRosen/upgrade-to-tachyon-0.8.2.

(cherry picked from commit 34e7093)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 34e7093 Dec 1, 2015
@JoshRosen JoshRosen deleted the upgrade-to-tachyon-0.8.2 branch December 1, 2015 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants