-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-12065] Upgrade Tachyon from 0.8.1 to 0.8.2 #10054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @calvinjia |
|
@JoshRosen |
|
Test build #46933 has finished for PR 10054 at commit
|
|
Jenkins, retest this please. |
|
Test build #46944 has finished for PR 10054 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, quick question: why do we need these exclusions? AFAIK tachyon-client is an uber-JAR which shades all of its dependencies: http://mvnrepository.com/artifact/org.tachyonproject/tachyon-client/0.8.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I guess we need this because the tachyon-client JAR still declares compile-scope dependencies on the artifacts that it shades and relocates, which will result in Tachyon client's shaded dependencies being pulled in. I'm a bit confused about why the tachyon-client JAR is published with a non-dependency-reduced POM.
This is corroborated by #8577, which needed to add additional exclusions because of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've filed https://tachyon.atlassian.net/browse/TACHYON-1380 to ask Tachyon to change the handling of dependencies in this POM for future releases. For now, though, I've verified that we don't need to change any of these exclusions because the client's dependencies haven't changed, so I think this PR should be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, there was some slight confusion here: I somehow parsed "Distribution of Tachyon client module with shaded packages in jar" as "shades all dependencies", which isn't true, so there's not an issue here. My bad.
This commit upgrades the Tachyon dependency from 0.8.1 to 0.8.2. Author: Josh Rosen <[email protected]> Closes #10054 from JoshRosen/upgrade-to-tachyon-0.8.2. (cherry picked from commit 34e7093) Signed-off-by: Josh Rosen <[email protected]>
This commit upgrades the Tachyon dependency from 0.8.1 to 0.8.2.