-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-12058][STREAMING][KINESIS][TESTS] fix Kinesis python tests #10050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #46910 has finished for PR 10050 at commit
|
|
@brkyvz could you enable |
|
jenkins retest this please |
|
Test build #46926 has finished for PR 10050 at commit
|
|
jenkins, test this please |
|
jenkins test this please |
|
Test build #47091 has finished for PR 10050 at commit
|
|
Test build #47090 has finished for PR 10050 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets name it KinesisDataGenerator, to avoid confusion with "producer" in KPL.
KinesisProducer --> KinesisDataGenerator
KinesisClientProducer --> SimpleDataGenerator
KinesisProducerLibraryProducer --> KPLDataGenerator
|
Test build #47102 has finished for PR 10050 at commit
|
|
Test build #2169 has finished for PR 10050 at commit
|
|
Test build #2170 has finished for PR 10050 at commit
|
|
LGTM. Merging this to master and 1.6. Thanks! |
Python tests require access to the `KinesisTestUtils` file. When this file exists under src/test, python can't access it, since it is not available in the assembly jar. However, if we move KinesisTestUtils to src/main, we need to add the KinesisProducerLibrary as a dependency. In order to avoid this, I moved KinesisTestUtils to src/main, and extended it with ExtendedKinesisTestUtils which is under src/test that adds support for the KPL. cc zsxwing tdas Author: Burak Yavuz <[email protected]> Closes #10050 from brkyvz/kinesis-py.
Python tests require access to the
KinesisTestUtilsfile. When this file exists under src/test, python can't access it, since it is not available in the assembly jar.However, if we move KinesisTestUtils to src/main, we need to add the KinesisProducerLibrary as a dependency. In order to avoid this, I moved KinesisTestUtils to src/main, and extended it with ExtendedKinesisTestUtils which is under src/test that adds support for the KPL.
cc @zsxwing @tdas