Skip to content

Conversation

@jerryshao
Copy link
Contributor

Currently when serializing TransformFunction, rdd_wrap_func object is not serialized into bytearray. So after deserializing, it will use default value, which will make Kafka direct stream transform wrongly recovered and throw exception.

Please help to review, thanks a lot.

@SparkQA
Copy link

SparkQA commented Nov 27, 2015

Test build #46823 has finished for PR 10017 at commit 3ff4b09.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 27, 2015

Test build #46824 has finished for PR 10017 at commit bfae0ab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor

tdas commented Dec 1, 2015

@zsxwing can you take a look at this?

@zsxwing
Copy link
Member

zsxwing commented Dec 1, 2015

@jerryshao LGTM except one minor issue in tests. Because we want to merge this fix today for 1.6, I just submitted #10074 to fix the issue in tests.

asfgit pushed a commit that referenced this pull request Dec 1, 2015
… recovery issue

Fixed a minor race condition in #10017

Closes #10017

Author: jerryshao <[email protected]>
Author: Shixiong Zhu <[email protected]>

Closes #10074 from zsxwing/review-pr10017.

(cherry picked from commit f292018)
Signed-off-by: Shixiong Zhu <[email protected]>
@asfgit asfgit closed this in f292018 Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants