[Doc] Explicitly state that top maintains the order of elements #10013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top is implemented in terms of takeOrdered, which already maintains the order, so top should, too.
Member
|
I think that's fine, though might say it a little differently. It returns the top k elements according to some ordering, and the k elements are in order ascending/descending. |
Contributor
Author
|
I've used the same wording that the docs of |
Member
|
I see your point, let's go with the same wording then, yes. |
|
Test build #2129 has finished for PR 10013 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 30, 2015
Top is implemented in terms of takeOrdered, which already maintains the order, so top should, too. Author: Wieland Hoffmann <[email protected]> Closes #10013 from mineo/top-order. (cherry picked from commit 26c3581) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top is implemented in terms of takeOrdered, which already maintains the
order, so top should, too.