Skip to content

[SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTransformer user guide and example code #10006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[SPARK-11958] [SPARK-11957] [ML] [Doc] SQLTransformer user guide and example code #10006

wants to merge 6 commits into from

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Nov 26, 2015

Add SQLTransformer user guide, example code and make Scala API doc more clear.

@yanboliang
Copy link
Contributor Author

yanboliang commented Nov 26, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Nov 26, 2015

Test build #46770 has finished for PR 10006 at commit 4c4049d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaSQLTransformerExample\n

@SparkQA
Copy link

SparkQA commented Nov 26, 2015

Test build #46771 has finished for PR 10006 at commit 4c4049d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaSQLTransformerExample\n

mengxr
mengxr reviewed Nov 30, 2015
View reviewed changes
R/pkg/DESCRIPTION Outdated
Copy link
Contributor

@mengxr mengxr Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not part of this PR

@mengxr
Copy link
Contributor

mengxr commented Nov 30, 2015

LGTM except one minor issue commented inline.

@SparkQA
Copy link

SparkQA commented Dec 1, 2015

Test build #46928 has finished for PR 10006 at commit 4ad27f9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaSQLTransformerExample\n

BenFradet
BenFradet reviewed Dec 2, 2015
View reviewed changes
docs/ml-features.md Outdated
Copy link
Contributor

@BenFradet BenFradet Dec 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supports and not supported

@BenFradet
Copy link
Contributor

BenFradet commented Dec 2, 2015

There are a few typos which need to be corrected, but otherwise it looks good.

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #47110 has finished for PR 10006 at commit ab44e9a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaSQLTransformerExample\n

BenFradet
BenFradet reviewed Dec 3, 2015
View reviewed changes
docs/ml-features.md Outdated
Copy link
Contributor

@BenFradet BenFradet Dec 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "the transformation which are defined by a SQL statement"?

Copy link
Contributor

@BenFradet BenFradet Dec 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cc @mengxr

@SparkQA
Copy link

SparkQA commented Dec 4, 2015

Test build #47181 has finished for PR 10006 at commit f59a5e3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaSQLTransformerExample\n

asfgit pushed a commit that referenced this pull request Dec 8, 2015
@yanboliang @mengxr
[SPARK-11958][SPARK-11957][ML][DOC] SQLTransformer user guide and exa…
5c82169 
…mple code

Add ```SQLTransformer``` user guide, example code and make Scala API doc more clear.

Author: Yanbo Liang <[email protected]>

Closes #10006 from yanboliang/spark-11958.

(cherry picked from commit 4a39b5a)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Dec 8, 2015

Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in 4a39b5a Dec 8, 2015
@yanboliang yanboliang deleted the spark-11958 branch December 8, 2015 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanboliang @SparkQA @mengxr @BenFradet