[SPARK-47889] Setup gradle as build tool for operator repository #4

jiangzho · 2024-04-17T19:51:16Z

This is a breakdown from #2 : set up gradle as the build-tool for operator

dongjoon-hyun · 2024-04-17T20:53:03Z

.gitignore

+gradle/wrapper/gradle-wrapper.jar
+
+# IDE specific files/directories #
+#######################################


This is irrelevant to Gradle, isn't it?

Despite not directly related - with plugin idea and eclipse, these files could be created after running init or build task.

Would you suggest adding them with another PR as well ?

.gitignore

dongjoon-hyun · 2024-04-17T20:53:36Z

build.gradle

+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+assert JavaVersion.current().isJava11Compatible(): "Java 11 or newer is required"


Please remove this file.

dongjoon-hyun · 2024-04-17T20:53:49Z

gradle.properties

+# limitations under the License.
+#
+#
+group=org.apache.spark.kubernetes.operator


Please remove this part.

dongjoon-hyun · 2024-04-17T20:54:07Z

settings.gradle

+// specific language governing permissions and limitations
+// under the License.
+
+rootProject.name = 'spark-kubernetes-operator'


Please remove this part.

dongjoon-hyun · 2024-04-17T20:56:46Z

gradle/wrapper/gradle-wrapper.properties

+
+distributionBase=GRADLE_USER_HOME
+distributionPath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip


Please use the latest 8.7.

https://gradle.org/releases/

v8.7 (Mar 22, 2024)

dongjoon-hyun · 2024-04-17T20:59:39Z

gradle/wrapper/gradle-wrapper.properties

+distributionPath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
+networkTimeout=10000
+validateDistributionUrl=true


Please remove this. This is still incubating.

https://docs.gradle.org/current/dsl/org.gradle.api.tasks.wrapper.Wrapper.html#org.gradle.api.tasks.wrapper.Wrapper:validateDistributionUrl

gradle/wrapper/gradle-wrapper.properties

dongjoon-hyun

Lastly, please update LICENSE file for your new addition. Here is the reference from Apache Iceberg project.

https://github.com/apache/iceberg/blob/228fc9b41f99f423d500a236c68216f0203dd42c/LICENSE#L204-L213

dongjoon-hyun · 2024-04-18T04:33:10Z

gradle.properties

@@ -0,0 +1,17 @@
+#


Like gradle/wrapper/gradle-wrapper.properties, please remove this empty line.

dongjoon-hyun · 2024-04-18T04:36:00Z

LICENSE

+
+* gradlew and gradle/wrapper/gradle-wrapper.properties
+
+Copyright: 2010-2019 Gradle Authors.


This PR has a conflict on the license year. Please use the YEAR of gradlew instead of this.

dongjoon-hyun · 2024-04-18T04:36:47Z

build.gradle

+// under the License.
+
+subprojects {
+    apply plugin: 'idea'


Apache Spark community uses 2-space indentation. Please fix the indentation.

dongjoon-hyun · 2024-04-18T04:38:28Z

build.gradle

+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+//         "License"); you may not use this file except in compliance


Did you change this line? The space before "License" looks wrong to me.

dongjoon-hyun · 2024-04-18T04:38:48Z

build.gradle

+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.


Let's use the following style. Please copy the following lines from Apache Iceberg .

https://github.com/apache/iceberg/blob/228fc9b41f99f423d500a236c68216f0203dd42c/baseline.gradle#L1-L18

dongjoon-hyun · 2024-04-18T04:39:02Z

build.gradle

+    apply plugin: 'eclipse'
+    apply plugin: 'java'
+    sourceCompatibility = 11
+    targetCompatibility = 11


Please use Java 17.

dongjoon-hyun · 2024-04-18T04:39:27Z

gradle/wrapper/gradle-wrapper.properties

+networkTimeout=10000
+zipStoreBase=GRADLE_USER_HOME
+zipStorePath=wrapper/dists
+distributionSha256Sum=544c35d6bd849ae8a5ed0bcea39ba677dc40f49df7d1835561582da2009b961d


Please move this to the next line of distributionUrl.

dongjoon-hyun · 2024-04-18T04:40:14Z

settings.gradle

+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.


Do we need this file? Please remove this empty file.

dongjoon-hyun · 2024-04-18T04:45:28Z

gradlew

+APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit
+
+if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
+    curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v8.6/gradle/wrapper/gradle-wrapper.jar


This PR has a conflict on Gradle version.

Here: v8.6

gradle/wrapper/gradle-wrapper.properties: v8.7

Please fix this line and double-check manually that we are using v8.7.

dongjoon-hyun

I finished the second round review..

Since there are conflicts in the PR, please resolve them and minimize the PR.

dongjoon-hyun · 2024-04-18T05:05:26Z

settings.gradle

@@ -0,0 +1,16 @@
+// Licensed to the Apache Software Foundation (ASF) under one


BTW, let's exclude all .gradle files by adding a new line here, @jiangzho .

spark-kubernetes-operator/.github/.licenserc.yaml

Line 10 in 7a3a7e8

- '**/*.md'

dongjoon-hyun

+1, LGTM. Thank you so much, @jiangzho .

dongjoon-hyun · 2024-04-18T16:30:09Z

Oh, my bad. I didn't check the PR builder on this PR.

### What changes were proposed in this pull request? This PR aims to add `gradlew` to `.licenserc.yaml` as a follow-up of - #4 ### Why are the changes needed? To recover CI. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No, Closes #5 from dongjoon-hyun/SPARK-47889. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

jiangzho force-pushed the gradle branch from 4a619ef to 8f6153e Compare April 17, 2024 20:24

dongjoon-hyun reviewed Apr 17, 2024

View reviewed changes

.gitignore Show resolved Hide resolved

dongjoon-hyun reviewed Apr 17, 2024

View reviewed changes

gradle/wrapper/gradle-wrapper.properties Show resolved Hide resolved

dongjoon-hyun requested changes Apr 17, 2024

View reviewed changes

jiangzho force-pushed the gradle branch 2 times, most recently from 16c2681 to 236c11b Compare April 17, 2024 21:34

dongjoon-hyun reviewed Apr 18, 2024

View reviewed changes

gradle.properties Outdated

@@ -0,0 +1,17 @@

#

Copy link

Member

dongjoon-hyun Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like gradle/wrapper/gradle-wrapper.properties, please remove this empty line.

dongjoon-hyun reviewed Apr 18, 2024

View reviewed changes

Setup gradle for Operator project

66a4002

jiangzho force-pushed the gradle branch from 236c11b to 66a4002 Compare April 18, 2024 07:00

dongjoon-hyun approved these changes Apr 18, 2024

View reviewed changes

dongjoon-hyun closed this in 5f2c89c Apr 18, 2024

dongjoon-hyun mentioned this pull request Apr 18, 2024

[SPARK-47889][FOLLOWUP] Add gradlew to .licenserc.yaml #5

Closed

dongjoon-hyun mentioned this pull request Apr 23, 2024

Operator 0.1.0 #2

Closed

jiangzho deleted the gradle branch July 23, 2024 23:05


		* gradlew and gradle/wrapper/gradle-wrapper.properties

		Copyright: 2010-2019 Gradle Authors.

		@@ -0,0 +1,16 @@
		// Licensed to the Apache Software Foundation (ASF) under one

[SPARK-47889] Setup gradle as build tool for operator repository #4

[SPARK-47889] Setup gradle as build tool for operator repository #4

Uh oh!

Conversation

jiangzho commented Apr 17, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants