[SPARK-53874] SparkAppDriverConf should respect sparkVersion of SparkApplication CRD
#385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SparkApplication` CRD
dongjoon-hyun
commented
Oct 11, 2025
| */ | ||
| @Override | ||
| public scala.collection.immutable.Map<String, String> labels() { | ||
| return super.labels().updated(LABEL_SPARK_VERSION_NAME, sparkVersion); |
Member
Author
There was a problem hiding this comment.
This overrides the underlying Spark version (from the compile dependency), 4.1.0-preview2.
Member
Author
|
cc @jiangzho , @peter-toth , @viirya . |
viirya
approved these changes
Oct 11, 2025
Member
Author
|
Thank you, @viirya ! Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
SparkAppDriverConfto respectsparkVersionofSparkApplicationCRD.Why are the changes needed?
This is a long standing bug from the initial implementation.
Since Apache Spark K8s Operator can launch various Spark versions,
spark-versionlabel should come fromSparkApplicationCRD'ssparkVersionfield.However, currently, the Spark version of compile dependency is used for
Driverresources (likeDriver PodandDriver Service. We should override this.Does this PR introduce any user-facing change?
Yes, this is a bug fix to use a correct version information.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.