[SPARK-49132] Minimize docker image by removing redundant chown commands
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Closed
Member
Author
|
Thank you, @jiangzho . |
viirya
approved these changes
Aug 7, 2024
Member
Author
|
Thank you, @viirya ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 19, 2024
…dencies ### What changes were proposed in this pull request? This PR aims to reduce `spark-operator` module's fat jar size by excluding dependencies ### Why are the changes needed? This PR reduces the size from `227M` to `148M`. It's `35%` reduction. **BEFORE** ``` $ ls -alh spark-operator/build/libs/spark-kubernetes-operator-0.1.0-all.jar -rw-r--r-- 1 dongjoon staff 227M Aug 18 23:09 spark-operator/build/libs/spark-kubernetes-operator-0.1.0-all.jar ``` **AFTER** ``` $ ls -alh spark-operator/build/libs/spark-kubernetes-operator-0.1.0-all.jar -rw-r--r-- 1 dongjoon staff 148M Aug 18 23:03 spark-operator/build/libs/spark-kubernetes-operator-0.1.0-all.jar ``` Please note that we reduced docker image from `892MB` to `654MB` by removing redundant `chown` commands before. After this PR, we have `571MB`. - #33 ``` $ docker images | head -n3 REPOSITORY TAG IMAGE ID CREATED SIZE spark-kubernetes-operator 0.1.0 657fadd103c9 About a minute ago 571MB ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? After passing the CIs, this should be tested manually. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #67 from dongjoon-hyun/SPARK-49298. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to minimize docker image from
892MBto654MBby removing redundantchowncommands.Why are the changes needed?
BEFORE
AFTER
Does this PR introduce any user-facing change?
No because this is not released yet.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.