[SPARK-49130] Verify built images in build-image CI job via docker run test
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Closed
Member
Author
|
Thank you, @jiangzho . |
viirya
approved these changes
Aug 6, 2024
Member
Author
|
Thank you, @viirya . Merged to main. |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 7, 2024
… run` test This PR aims to verify built images in `build-image` CI job via `docker run` test As we observed at #31 , the existing CI may build a corrupted image because we didn't verify it. - #31 No, this is a test on our CI infra. Pass the CIs. We can see the result of `docker run` like the following. - https://github.com/apache/spark-kubernetes-operator/actions/runs/10274277967/job/28430624083?pr=32  No. Closes #32 from dongjoon-hyun/SPARK-45923. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
changed the title
build-image CI job via docker run testbuild-image CI job via docker run test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to verify built images in
build-imageCI job viadocker runtestWhy are the changes needed?
As we observed at #31 , the existing CI may build a corrupted image because we didn't verify it.
ENTRYPOINTto point/opt/spark-operator/operator/docker-entrypoint.sh#31Does this PR introduce any user-facing change?
No, this is a test on our CI infra.
How was this patch tested?
Pass the CIs. We can see the result of
docker runlike the following.Was this patch authored or co-authored using generative AI tooling?
No.