[SPARK-49019] Use try-with-resources to test KubernetesClientFactory.buildKubernetesClient
#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry.buildKubernetesClient`
Member
Author
|
Could you review this PR, @viirya ? |
Member
Author
|
Could you review this PR, @huaxingao ? |
viirya
approved these changes
Jul 26, 2024
huaxingao
approved these changes
Jul 26, 2024
Member
Author
|
Thank you, @viirya and @huaxingao . |
Member
Author
|
Merged to main. |
Closed
jiangzho
pushed a commit
to jiangzho/spark-kubernetes-operator
that referenced
this pull request
Jul 17, 2025
…ry.buildKubernetesClient` ### What changes were proposed in this pull request? This PR aims to use `try-with-resources` to test `KubernetesClientFactory.buildKubernetesClient`. ### Why are the changes needed? To be safe during the testing. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#25 from dongjoon-hyun/SPARK-49019. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jiangzho
added a commit
to jiangzho/spark-kubernetes-operator
that referenced
this pull request
Jul 17, 2025
Sync main branch with Apple internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
try-with-resourcesto testKubernetesClientFactory.buildKubernetesClient.Why are the changes needed?
To be safe during the testing.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.