Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jul 19, 2024

What changes were proposed in this pull request?

This PR aims to use BasePluginExtension in spark-operator/build.gradle.

Why are the changes needed?

BEFORE

$ ./gradlew test --warning-mode all

> Configure project :spark-operator
Build file '/Users/dongjoon/APACHE/spark-kubernetes-operator/spark-operator/build.gradle': line 59
The BasePluginExtension.archivesBaseName property has been deprecated. This is scheduled to be removed in Gradle 9.0. Please use the archivesName property instead. For more information, please refer to https://docs.gradle.org/8.7/dsl/org.gradle.api.plugins.BasePluginExtension.html#org.gradle.api.plugins.BasePluginExtension:archivesName in the Gradle documentation.
        at build_1pl46tz9v8uzxd6mxgrewtcjs$_run_closure5.doCall$original(/Users/dongjoon/APACHE/spark-kubernetes-operator/spark-operator/build.gradle:59)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        at build_1pl46tz9v8uzxd6mxgrewtcjs.run(/Users/dongjoon/APACHE/spark-kubernetes-operator/spark-operator/build.gradle:56)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

> Configure project :spark-operator-api
Updating PrinterColumns for generated CRD

BUILD SUCCESSFUL in 394ms
13 actionable tasks: 13 up-to-date

AFTER

$ ./gradlew test --warning-mode all

> Configure project :spark-operator-api
Updating PrinterColumns for generated CRD

BUILD SUCCESSFUL in 391ms
13 actionable tasks: 13 up-to-date

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs and do manual test with ./gradlew test --warning-mode all.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @viirya ?

@dongjoon-hyun
Copy link
Member Author

Also, cc @jiangzho , too

Copy link

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @huaxingao !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-48952 branch July 19, 2024 23:28
@dongjoon-hyun
Copy link
Member Author

Merged to main.

@dongjoon-hyun dongjoon-hyun mentioned this pull request Jul 29, 2024
jiangzho pushed a commit to jiangzho/spark-kubernetes-operator that referenced this pull request Jul 17, 2025
### What changes were proposed in this pull request?

This PR aims to use `BasePluginExtension` in `spark-operator/build.gradle`.

### Why are the changes needed?

**BEFORE**
```
$ ./gradlew test --warning-mode all

> Configure project :spark-operator
Build file '/Users/dongjoon/APACHE/spark-kubernetes-operator/spark-operator/build.gradle': line 59
The BasePluginExtension.archivesBaseName property has been deprecated. This is scheduled to be removed in Gradle 9.0. Please use the archivesName property instead. For more information, please refer to https://docs.gradle.org/8.7/dsl/org.gradle.api.plugins.BasePluginExtension.html#org.gradle.api.plugins.BasePluginExtension:archivesName in the Gradle documentation.
        at build_1pl46tz9v8uzxd6mxgrewtcjs$_run_closure5.doCall$original(/Users/dongjoon/APACHE/spark-kubernetes-operator/spark-operator/build.gradle:59)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        at build_1pl46tz9v8uzxd6mxgrewtcjs.run(/Users/dongjoon/APACHE/spark-kubernetes-operator/spark-operator/build.gradle:56)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

> Configure project :spark-operator-api
Updating PrinterColumns for generated CRD

BUILD SUCCESSFUL in 394ms
13 actionable tasks: 13 up-to-date
```

**AFTER**
```
$ ./gradlew test --warning-mode all

> Configure project :spark-operator-api
Updating PrinterColumns for generated CRD

BUILD SUCCESSFUL in 391ms
13 actionable tasks: 13 up-to-date
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs and do manual test with `./gradlew test --warning-mode all`.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#18 from dongjoon-hyun/SPARK-48952.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
jiangzho added a commit to jiangzho/spark-kubernetes-operator that referenced this pull request Jul 17, 2025
Add ability to reconcile Apple Spark Clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants