Skip to content

Conversation

@ehoner
Copy link
Contributor

@ehoner ehoner commented Jun 22, 2023

Remove @Deprecated. This annotation was missed when updating #1662 - (comment).

@mynameborat
Copy link
Contributor

Will have it merged once the checks pass

@ehoner
Copy link
Contributor Author

ehoner commented Jun 22, 2023

Thank you @mynameborat . I was looking at the failure, do you know how/if the error relates to this PR? The failure is in TestSamzaSqlEndToEnd.

CI build: 8.0.232

> Task :samza-test_2.12:test

testEndToEndStreamTableInnerJoinWithUdf FAILED
    java.lang.AssertionError: expected:<20> but was:<19>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at org.apache.samza.test.samzasql.TestSamzaSqlEndToEnd.testEndToEndStreamTableInnerJoinWithUdf(TestSamzaSqlEndToEnd.java:892)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants