Skip to content

Fix Qpid::Proton::DEFAULT_URI_PARSER for Ruby 3.4 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix Qpid::Proton::DEFAULT_URI_PARSER for Ruby 3.4 #439

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c13f58
Fix Qpid::Proton::DEFAULT_URI_PARSER for Ruby 3.4
eduresende Feb 20, 2025
72947b5
refactoring parser
eduresende Feb 21, 2025
62f7a0a
define DEFAULT_URI_PARSER according to Ruby version
eduresende Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ruby/lib/core/uri.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ class AMQPS < AMQP
module Qpid::Proton
private
# Make sure to allow empty hostnames, Ruby 2.0.0 does not.
DEFAULT_URI_PARSER = URI::Parser.new(:HOSTNAME => /(?:#{URI::PATTERN::HOSTNAME})|/)
DEFAULT_URI_PARSER =
if RUBY_VERSION >= '3.4'
URI::RFC2396_Parser.new(:HOSTNAME => /(?:#{URI::PATTERN::HOSTNAME})|/)
else
URI::Parser.new(:HOSTNAME => /(?:#{URI::PATTERN::HOSTNAME})|/)
end

public

Expand Down
Loading