Fix Trino Getting-started Example #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonahX
commented
Jan 24, 2025
| iceberg.rest-catalog.oauth2.token=principal:root;realm:default-realm | ||
| iceberg.rest-catalog.warehouse=polaris | ||
| # Required to support local filesystem: https://trino.io/docs/current/object-storage.html#configuration | ||
| fs.hadoop.enabled=true |
Contributor
Author
There was a problem hiding this comment.
This is related to a breaking change in Trino iceberg connector: link
We have to explicitly enable filesystem support : https://trino.io/docs/current/object-storage.html#configuration
HonahX
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
jbonofre
approved these changes
Jan 24, 2025
| ## Build Polaris Image | ||
| Build Polaris Image while Docker is running | ||
| ``` | ||
| ./gradlew :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true |
Member
There was a problem hiding this comment.
General question (not about this PR specificaly): should not we rename polaris-quarkus-server to polaris-server now ? @adutra thoughts ?
Contributor
There was a problem hiding this comment.
Not opposed to a global renaming and removing the quarkus token from all module names 👍
| iceberg.rest-catalog.oauth2.token=principal:root;realm:default-realm | ||
| iceberg.rest-catalog.warehouse=polaris | ||
| # Required to support local filesystem: https://trino.io/docs/current/object-storage.html#configuration | ||
| fs.hadoop.enabled=true |
adutra
reviewed
Jan 24, 2025
| AZURE_CLIENT_SECRET: $AZURE_CLIENT_SECRET | ||
| # add aws keys as dropwizard config | ||
| JAVA_OPTS: -Ddw.awsAccessKey=$AWS_ACCESS_KEY_ID -Ddw.awsSecretKey=$AWS_SECRET_ACCESS_KEY | ||
| polaris.persistence.type: in-memory |
Contributor
There was a problem hiding this comment.
Sorry I missed that docker-compose file, I should have adapted it to Quarkus earlier. My bad.
adutra
approved these changes
Jan 24, 2025
eric-maynard
approved these changes
Jan 24, 2025
Contributor
Author
Contributor
|
Thanks @HonahX for the fix. Thanks @adutra @jbonofre and @eric-maynard for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Trino example to make it working again. There are 2 major part of changes
fs.hadoop.enabled=trueto enable Local Filesystem support for Trino